Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aria label for chat button to match link text #4406

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

sarahcrack
Copy link
Collaborator

Trello card

https://trello.com/c/4FhYDfev/7100-update-or-remove-aria-label-for-chat-button-in-footer

Context

One of our new accessibility tools, ARC Toolkit, has flagged that the aria label for the chat button in the footer is now different to the visible text. This means that people using assistive technologies may have problems accessing the link.

Changes proposed in this pull request

Updated aria label for chat button to match link text i.e. "Open chat in new tab".

Guidance to review

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

@github-actions github-actions bot added the Review label Dec 5, 2024
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tested successfully using ARC Toolkit and VoiceOver

Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sarahcrack sarahcrack merged commit 5f95e9d into master Dec 5, 2024
28 checks passed
@sarahcrack sarahcrack deleted the update-aria-label-chat-button branch December 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants